prepare for mapdb backend #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
requested changes
Feb 18, 2019
| return Collections.emptyIterator(); | ||
| } | ||
| return super.query(q); | ||
| } else { |
There was a problem hiding this comment.
Remove the else, the code inside the brackets is slightly longer
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphTransaction.java
Show resolved
Hide resolved
javeme
force-pushed
the
mapdb-prepare
branch
from
db8b560 to
f4e7718
Compare
Change-Id: I046bde4a32b3fd6693f788d27a9165e2646bc5cb
javeme
force-pushed
the
mapdb-prepare
branch
from
f4e7718 to
504b1c2
Compare
Linary
previously approved these changes
Mar 4, 2019
zhoney
requested changes
Mar 5, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BytesBuffer.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BytesBuffer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BytesBuffer.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
============================================
+ Coverage 67.54% 67.65% +0.11%
- Complexity 3145 3172 +27
============================================
Files 201 203 +2
Lines 16010 16078 +68
Branches 2327 2343 +16
============================================
+ Hits 10814 10878 +64
- Misses 3980 3988 +8
+ Partials 1216 1212 -4
Continue to review full report at Codecov.
|
javeme
force-pushed
the
mapdb-prepare
branch
7 times, most recently
from
d2590c8 to
9290022
Compare
Change-Id: I7e3c9677f5d824b37a64791b87cfca5c649c74db
Linary
approved these changes
Mar 6, 2019
zhoney
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I046bde4a32b3fd6693f788d27a9165e2646bc5cb